----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4290/#review14038 -----------------------------------------------------------
branches/13/res/res_pjsip/pjsip_options.c <https://reviewboard.asterisk.org/r/4290/#comment24556> Since we are now removing all qualifies during a reload, do we still need an explicit call to unschedule_qualify on contact creation? We should now be guaranteed on contact creation that, if the contact previously existed, we already destroyed its entry in the scheduler. - Matt Jordan On Dec. 22, 2014, 12:21 p.m., George Joseph wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4290/ > ----------------------------------------------------------- > > (Updated Dec. 22, 2014, 12:21 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > If you remove an endpoint/aor from pjsip.conf then do a core reload, > qualifies will continue even though the object are gone. This happens > because nothing clears out the qualify tasks. > > This patch unschedules all existing qualify tasks before scheduling new ones > on reload. > > > Diffs > ----- > > branches/13/res/res_pjsip/pjsip_options.c 430001 > > Diff: https://reviewboard.asterisk.org/r/4290/diff/ > > > Testing > ------- > > Verified with Wireshark that the OPTIONS messages stop and ran the testsuite > for all pjsip tests and verified that all tests pass. > > > Thanks, > > George Joseph > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
