> On Jan. 6, 2015, 1:34 p.m., George Joseph wrote: > > So, I applied the patch but am having trouble seeing what this does in real > > life. res_pjsip can only load by itself if there's no configuration. Even > > a minimal one requires res_pjsip_session and > > res_pjsip_outbound_authenticator_digest. So in the end, you have to reload > > with no config, then start unloading modules. Why not just restart with > > the stack noloaded in modules.conf? > > > > George Joseph wrote: > Also you might want to update MODULEINFO to indicate that > res_sorcery_config, res_sorcery_memory and res_sorcery_astdb are require to > load res_pjsip in the first place. > > > George Joseph wrote: > Unloading res_pjsip_outbound_registration segfaults if there's a > registration defined. :) > > Kevin Harwell wrote: > [My fault for not explaining the reasoning behind the patch better] This > patch is the first step (should hopefully be followed by another/others at > some point) in allowing res_pjsip and the modules that depend on it to be > unloadable. At this time, as you noted, res_pjsip and some of the modules > that depend on res_pjsip cannot be unloaded without causing problems of some > sort. > > The goal of this patch is to get res_pjsip and only res_pjsip to be able > to unload successfully and/or shutdown without incident (crashes, leaks, > etc...). Other dependent modules will still cause problems on unload > (res_pjsip_session, res_pjsip_pubsub, etc...). > > So yeah basically I just made sure, with the patch applied, that > res_pjsip (with no other dependent modules loaded) could be succesfully > unloaded and Asterisk could shutdown without any leaks or crashes that > pertained directly to res_pjsip.
Ah, sounds good. I did test that it was indeed unloadable. - George ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4311/#review14093 ----------------------------------------------------------- On Jan. 6, 2015, 2:30 p.m., Kevin Harwell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4311/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2015, 2:30 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24485 > https://issues.asterisk.org/jira/browse/ASTERISK-24485 > > > Repository: Asterisk > > > Description > ------- > > The res_pjsip module was previously unloadable. With this patch it can now be > unloaded. > > This patch is based off the original patch on the issue by Corey Farrell with > a few modifications. Removed a few changes not required to make the module > unloadable and also fixed a bug that would cause asterisk to crash on > unloading. > > > Diffs > ----- > > branches/13/res/res_pjsip/pjsip_outbound_auth.c 430244 > branches/13/res/res_pjsip/pjsip_options.c 430244 > branches/13/res/res_pjsip/pjsip_global_headers.c 430244 > branches/13/res/res_pjsip/pjsip_distributor.c 430244 > branches/13/res/res_pjsip/pjsip_configuration.c 430244 > branches/13/res/res_pjsip/location.c 430244 > branches/13/res/res_pjsip/include/res_pjsip_private.h 430244 > branches/13/res/res_pjsip/config_transport.c 430244 > branches/13/res/res_pjsip/config_auth.c 430244 > branches/13/res/res_pjsip.c 430244 > branches/13/main/stasis_message_router.c 430244 > > Diff: https://reviewboard.asterisk.org/r/4311/diff/ > > > Testing > ------- > > Made it so res_pjsip was the only pjsip module loaded and then issued an > unload and noted it unloaded successfully (also loaded/unloaded it several > times from the CLI). Also when loaded and with REF_DEBUG enabled issued a > "core stop gracefully" and made sure there were no ref leaks for the module. > > Also tested unloading with other dependent pjsip modules loaded and noted > that the module would not unload (as it should since dependencies are > currently loaded). And then shutdown asterisk and made sure it did not crash > or anything. > > Started asterisk with nominal and off nominal module and pjsip configurations > to make sure things behaved appropriately (no crashes and such) and then > attempted to, or successfully unload the res_pjsip module. Also made sure > Asterisk continued to shutdown without incident. > > > Thanks, > > Kevin Harwell > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
