> On Jan. 12, 2015, 7:59 p.m., Mark Michelson wrote: > > Just to double-check, have you tested the inverse? In other words, have you > > downgraded your PJSIP installation to something before > > pjsip_get_dest_info() existed and tested that the configure check fails > > (and subsequently that the new warning prints)?
Affirmative. - Joshua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4329/#review14162 ----------------------------------------------------------- On Jan. 12, 2015, 4:26 p.m., Joshua Colp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4329/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2015, 4:26 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24665 > https://issues.asterisk.org/jira/browse/ASTERISK-24665 > > > Repository: Asterisk > > > Description > ------- > > The 'secure' argument for chan_pjsip was changed in a previous commit to use > the pjsip_get_dest_info function to determine if a secure transport is being > used for signaling. This function, however, was added as of PJSIP 2.3 and is > not in earlier versions. If an earlier version is installed the build may > fail and loading the module may also fail. > > This change adds a configure check to determine if the pjsip_get_dest_info > function is present. If it is not present the 'secure' argument won't work > but everything else will continue as before. > > > Diffs > ----- > > /branches/13/include/asterisk/autoconfig.h.in 430491 > /branches/13/configure.ac 430491 > /branches/13/configure UNKNOWN > /branches/13/channels/pjsip/dialplan_functions.c 430491 > > Diff: https://reviewboard.asterisk.org/r/4329/diff/ > > > Testing > ------- > > Ran configure check, confirmed it found the support. > > > Thanks, > > Joshua Colp > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
