-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4328/#review14168
-----------------------------------------------------------
* Under 'URI Parsing' it states: "For the purposes of transport selection the
transport parameter is examined." I suggest clarifing that the transport
parameter being spoke of is the 'transport' parameter for endpoint types in
pjsip.conf.
* Under 'DNS SRV Resolution (If host portion is not an IP address)' it states:
"This means that the original URI *must* include..." I believe 'must' should be
bold without the surrounding '*'.
* Under 'Best Configuration Strategies':
* 'IPv4 Only (Single Interface)' it states "Configure a wildcard
transport." Does this mean not specifying the 'transport' parameter on
endpoints? I suggest to clarify this and to include an endpoint in the
configuration showing that the 'transport' parameter is not specified (assuming
thats what this example is about).
* 'IPv4 Only (Multiple Interfaces)': it states "This allows each transport
to be specified on endpoints...". Some clarification on whether this means
specifying a single transport using the 'transport' parameter or specifying
multiple transports using multiple 'transport' parameters for a single
endpoint? I also suggest to include configuration of endpoints showing the
'transport' parameter being used for the example.
* I suggest to either add additional examples with TLS transports. One
showing the recommended way to configure endpoints where some use UDP and
others use TLS.
- jbigelow
On Jan. 12, 2015, 7:33 a.m., Joshua Colp wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4328/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2015, 7:33 a.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> The transport selection process of PJSIP (and by extension some of our own
> logic) can be a dark dark thing. To help illuminate what happens I have
> created a wiki page[1] which goes through (based on the message type) the
> process by which a transport is chosen and how it can potentially change.
>
> Stuff to look at:
> 1. Is this detailed enough?
> 2. Can you follow it? If not, how could it be made clearer?
> 3. Are there additional common issues that should be covered?
>
> [1] https://wiki.asterisk.org/wiki/display/~jcolp/Transport+Selection
>
>
> Diffs
> -----
>
>
> Diff: https://reviewboard.asterisk.org/r/4328/diff/
>
>
> Testing
> -------
>
> I opened the wiki page. It opened.
>
>
> Thanks,
>
> Joshua Colp
>
>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
