-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4343/
-----------------------------------------------------------
Review request for Asterisk Developers.
Bugs: ASTERISK-24624
https://issues.asterisk.org/jira/browse/ASTERISK-24624
Repository: testsuite
Description
-------
This runs the test scenario as described in ASTERISK-24624. Asterisk places a
call to a SIPp scenario. The SIPp scenario performs a blind transfer to a bad
extension in the dialplan. After being notified that the blind transfer failed,
the SIPp scenario sends a reinvite to Asterisk. Asterisk should send a BYE
immediately. In addition, the channel test condition is used to ensure that no
channels exist after the test completes.
There is also a subtle bug that is fixed in the channel test condition. The
Asterisk CLI aims to be grammatically correct, and so if there is only one
active channel, it lists "1 active channel" in the CLI output of "core show
channels". However, the test condition was specifically looking for "active
channels" in order to determine the number of active channels. I tweaked the
test condition to just look for the string "active channel" since that will be
present for any number of active channels. I found this when running the test
without the corresponding Asterisk patch and wondering why the channel test
condition was not complaining about the remaining active channel.
Diffs
-----
/asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/tests.yaml 6075
/asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/off_nominal/transferer_reinvite/test-config.yaml
PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/off_nominal/transferer_reinvite/sipp/transferer.xml
PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/off_nominal/transferer_reinvite/configs/ast1/pjsip.conf
PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/off_nominal/transferer_reinvite/configs/ast1/extensions.conf
PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/off_nominal/tests.yaml
PRE-CREATION
/asterisk/trunk/lib/python/asterisk/channel_test_condition.py 6075
Diff: https://reviewboard.asterisk.org/r/4343/diff/
Testing
-------
I verified that the patch on /r/4339 this test passes. If that patch is not
applied, then the SIPp scenario fails and the channel test condition raises an
error since there is an active channel at the completion of the test.
Thanks,
Mark Michelson
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
