----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4340/#review14199 -----------------------------------------------------------
Ship it! /branches/13/res/res_fax_spandsp.c <https://reviewboard.asterisk.org/r/4340/#comment24653> When you commit this, please commit the white space changes as a separate commit. - Matt Jordan On Jan. 14, 2015, 3:19 p.m., rmudgett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4340/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2015, 3:19 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > When FAX was developed, apparently the faxregistry.container used to be a > linked list that was converted to an ao2 container. Some of the replacement > ao2 container operations still had explicit lock/unlocks around them. > > Three off nominal code paths in res_fax.c and res_fax_spandsp.c unlock the > channel even though the routine did not lock the channel and other code paths > in the routine do not unlock the channel. > > > Diffs > ----- > > /branches/13/res/res_fax_spandsp.c 430609 > /branches/13/res/res_fax.c 430609 > > Diff: https://reviewboard.asterisk.org/r/4340/diff/ > > > Testing > ------- > > The testsuite fax tests still pass. > > > Thanks, > > rmudgett > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
