----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4337/#review14201 -----------------------------------------------------------
Ship it! That's all I was looking at. :) - rmudgett On Jan. 15, 2015, 9:16 a.m., Matt Jordan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4337/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2015, 9:16 a.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24682 > https://issues.asterisk.org/jira/browse/ASTERISK-24682 > > > Repository: testsuite > > > Description > ------- > > This patch updates the following tests to verify that mid-call Macros/GoSubs > whose MACRO_RESULT/GOSUB_RESULT is set to an unknown value does not result in > multiple DialEnd events. The test spawns an additional channel that calls a > mid-call Macro/GoSub that returns, in its variable, a value that the Dial > application does not understand. The test verifies that the two channels are > bridged as expected, and that only a single DialEnd event is received. > > Note: this patch covers the code change in r4336. > > > Diffs > ----- > > /asterisk/trunk/tests/apps/dial/mid_call_events/dial_macro/test-config.yaml > 6274 > > /asterisk/trunk/tests/apps/dial/mid_call_events/dial_macro/configs/ast1/extensions.conf > 6274 > /asterisk/trunk/tests/apps/dial/mid_call_events/dial_gosub/test-config.yaml > 6274 > > /asterisk/trunk/tests/apps/dial/mid_call_events/dial_gosub/configs/ast1/extensions.conf > 6274 > > Diff: https://reviewboard.asterisk.org/r/4337/diff/ > > > Testing > ------- > > With Asterisk 13, verified that the expected events are received with the > patch on r4336. > > With Asterisk 11, verified that the test completes successfully. Note that > Asterisk 11 does not raise multiple AMI events. > > > Thanks, > > Matt Jordan > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
