----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4346/#review14215 -----------------------------------------------------------
Ship it! Looks sane to me. Thanks for the explanation of the mwi->call removal. Regarding the question of DRY; properly named functions trumps DRY. Renaming the function (or merging it into a single one) would've worked for me too. Minor nit below: /branches/11/channels/chan_sip.c <https://reviewboard.asterisk.org/r/4346/#comment24676> No need for the initial value and the if here anymore. - wdoekes On Jan. 16, 2015, 4:35 p.m., Mark Michelson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4346/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2015, 4:35 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24646 > https://issues.asterisk.org/jira/browse/ASTERISK-24646 > > > Repository: Asterisk > > > Description > ------- > > Please see the description on /r/4345 for a description of the > interoperability problem. > > This patch is the chan_sip version of the patch. The chan_sip patch is a bit > more weird since creation of Contact headers is not divided into dialog vs. > non-dialog situations. For this patch, I have expanded the build_contact() > function to base the scheme of the Contact header based on the rules of RFC > 3261 sections 8.1.1.8 and 12.1.1. To do this, I have added two parameters so > that it is clear whether the Contact header is being created due to a > response to an incoming request or if the Contact is being added to a created > outgoing request. > > > Diffs > ----- > > /branches/11/channels/chan_sip.c 428405 > > Diff: https://reviewboard.asterisk.org/r/4346/diff/ > > > Testing > ------- > > This patch has been tested by the reporter of ASTERISK-24646 and has been > confirmed to solve the interop issue. > > > Thanks, > > Mark Michelson > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
