----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4348/#review14220 -----------------------------------------------------------
Ship it! Ship It! - Matt Jordan On Jan. 15, 2015, 4:44 p.m., Ashley Sanders wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4348/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2015, 4:44 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24560 > https://issues.asterisk.org/jira/browse/ASTERISK-24560 > > > Repository: testsuite > > > Description > ------- > > Currently in ARI (Asterisk REST Interface), posting to the: > /ari/bridges/{bridgeId} endpoint without specifying a value for the [name] > query parameter, will crash Asterisk if the bridge you are attempting to > create (or update) has the same ID as an existing bridge. The internal > mechanism of the POST operation interprets a null value for name, thus > resulting in an error condition that crashes Asterisk. > > The first step in resolving this was to construct tests to ensure that > Asterisk behaves as expected when submitting requests for creating a new > bridge when a bridge with the same ID already exists in memory. The expected > behavior is to reject such requests and return an HTTP status code of 500 > (Internal Server Error). > > ***This is the test. It is only the test.*** By itself, this patch will crash > asterisk (which actually confirms the issue). You can find the review for the > Asterisk source at: https://reviewboard.asterisk.org/r/4349 > > > Diffs > ----- > > ./asterisk/trunk/tests/rest_api/bridges/tests.yaml 6126 > ./asterisk/trunk/tests/rest_api/bridges/error/test-config.yaml PRE-CREATION > ./asterisk/trunk/tests/rest_api/bridges/error/error.py PRE-CREATION > ./asterisk/trunk/tests/rest_api/bridges/error/configs/ast1/extensions.conf > PRE-CREATION > > Diff: https://reviewboard.asterisk.org/r/4348/diff/ > > > Testing > ------- > > > Thanks, > > Ashley Sanders > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
