-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4363/
-----------------------------------------------------------
Review request for Asterisk Developers.
Bugs: ASTERISK-24485
https://issues.asterisk.org/jira/browse/ASTERISK-24485
Repository: Asterisk
Description
-------
The res_pjsip module was previously unloadable. With this patch it can now be
unloaded.
This patch is based off the original patch on the issue by Corey Farrell with a
few modifications. Removed a few changes not required to make the module
unloadable and also fixed a bug that would cause asterisk to crash on unloading.
The first patch (found here: https://reviewboard.asterisk.org/r/4311/) had to
be reverted due to a race condition it introduced on shutdown. It turned out
that the following change to stasis_message_router was the cause (~line 258):
router->subscription = stasis_unsubscribe(router->subscription);
The patch found here is the original patch plus the fix for the problem (added
locking).
Diffs
-----
branches/13/res/res_pjsip/pjsip_outbound_auth.c 430884
branches/13/res/res_pjsip/pjsip_options.c 430884
branches/13/res/res_pjsip/pjsip_global_headers.c 430884
branches/13/res/res_pjsip/pjsip_distributor.c 430884
branches/13/res/res_pjsip/pjsip_configuration.c 430884
branches/13/res/res_pjsip/location.c 430884
branches/13/res/res_pjsip/include/res_pjsip_private.h 430884
branches/13/res/res_pjsip/config_transport.c 430884
branches/13/res/res_pjsip/config_auth.c 430884
branches/13/res/res_pjsip.c 430884
branches/13/main/stasis_message_router.c 430884
Diff: https://reviewboard.asterisk.org/r/4363/diff/
Testing
-------
Ran the relevant unit and testsuite tests on two different machines since
original patch passed on one. Also verified that the module could unload and
shutdown properly without any extra dependencies.
Thanks,
Kevin Harwell
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
