----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4365/#review14264 -----------------------------------------------------------
I didnt' make it to the actual AMQP code before having to leave, but I have some comments on the first few files in the diff. /branches/13/cdr/cdr_amqp.c <https://reviewboard.asterisk.org/r/4365/#comment24742> This needs to have details filled in. /branches/13/cdr/cdr_amqp.c <https://reviewboard.asterisk.org/r/4365/#comment24744> Probably a good idea to have an error message here. It doesn't look like ast_json_dump_string() prints an error message of its own. /branches/13/cel/cel_amqp.c <https://reviewboard.asterisk.org/r/4365/#comment24745> This needs to be filled in. /branches/13/cel/cel_amqp.c <https://reviewboard.asterisk.org/r/4365/#comment24746> Another place where an error message seems necessary. /branches/13/configs/samples/amqp.conf.sample <https://reviewboard.asterisk.org/r/4365/#comment24747> There are loads of red blobs on reviewboard in this and the other sample config files due to the mix of tabs and spaces. I recommend using nothing but spaces here so that users with different tab widths will have properly-aligned comments. - Mark Michelson On Jan. 21, 2015, 8:26 p.m., David Lee wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4365/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 8:26 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > This patch adds an AMQP backend for both CDR and CEL. This allows these > logs to be dispatched to a message broker, such as RabbitMQ, where they > can reliably be queued for transmission to the handling application. > > The res_amqp module adds core AMQP protocol support. The provided API > only supports publishing, since that's all that's needed for CDR/CEL. > The AMQP feature of supporting multiple 'channels' per connection was > also omitted. The underlying librabbitmq library is not thread safe, so > the multiplexing benefits are limited. It also makes using the library > more complicated, since clients have to worry about both connections and > channels. > > The cdr_amqp module simply registers a CDR backend which encodes CDRs as > JSON, and publishes them to an AMQP connection. > > The cel_amqp module similarly registers a CEL backend, which encodes > CELs as JSON, and publishes them to an AMQP connection. > > > Diffs > ----- > > /branches/13/res/res_pjsip_config_wizard.c 430900 > /branches/13/res/res_amqp.exports.in PRE-CREATION > /branches/13/res/res_amqp.c PRE-CREATION > /branches/13/res/amqp/internal.h PRE-CREATION > /branches/13/res/amqp/config.c PRE-CREATION > /branches/13/res/amqp/cli.c PRE-CREATION > /branches/13/res/Makefile 430900 > /branches/13/makeopts.in 430900 > /branches/13/include/asterisk/cel.h 430900 > /branches/13/include/asterisk/autoconfig.h.in 430900 > /branches/13/include/asterisk/amqp.h PRE-CREATION > /branches/13/contrib/scripts/install_prereq 430900 > /branches/13/configure.ac 430900 > /branches/13/configs/samples/cel_amqp.conf.sample PRE-CREATION > /branches/13/configs/samples/cdr_amqp.conf.sample PRE-CREATION > /branches/13/configs/samples/amqp.conf.sample PRE-CREATION > /branches/13/cel/cel_amqp.c PRE-CREATION > /branches/13/cdr/cdr_amqp.c PRE-CREATION > /branches/13/build_tools/menuselect-deps.in 430900 > > Diff: https://reviewboard.asterisk.org/r/4365/diff/ > > > Testing > ------- > > Ran amqp-consume to print messages sent to queues. > > Confirmed that the amqp test command sent messages properly. > > Confirmed that CDRs were properly sent. > > Confirmed that CELs were properly sent. > > > Thanks, > > David Lee > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
