> On Jan. 21, 2015, 5:19 p.m., rmudgett wrote: > > /trunk/apps/app_followme.c, lines 1464-1465 > > <https://reviewboard.asterisk.org/r/4095/diff/1/?file=68420#file68420line1464> > > > > It would be safer if the prompt wasn't played if the string is empty. > > This way you don't need a silence/0 default sound file. > > > > if (!ast_strlen_zero(targs->conprompt) { > > /* Play "connecting" message to the winner. */ > > ast_stream_and_wait() > > }
Fixed - will upload new diff just as soon as I figure out how. - Graham ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4095/#review14255 ----------------------------------------------------------- On Jan. 20, 2015, 5:16 a.m., Graham Mainwaring wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4095/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2015, 5:16 a.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24372 > https://issues.asterisk.org/jira/browse/ASTERISK-24372 > > > Repository: Asterisk > > > Description > ------- > > This patch adds the ability to configure a prompt which will be read to the > "winner" who pressed 1 (or the configured value) and received the call. > > The context of this is that I have users who only receive outbound follow-me > calls occasionally. These users have complained that when they are connected > to the inbound caller, they don't always remember to say hello as if the call > just arrived, so there is an awkward moment where the two parties figure out > they are connected. > > My prompt here says "Connecting. After the beep, please say hello to the > caller. <beep>." This reminds the follow-me winner that they ought to say > hello. > > I have configured this with a default of silence/0 so that the system's > behavior will not change for anyone who does not have this configured. > > > Diffs > ----- > > /trunk/configs/samples/followme.conf.sample 425984 > /trunk/apps/app_followme.c 425984 > > Diff: https://reviewboard.asterisk.org/r/4095/diff/ > > > Testing > ------- > > I have been running this in production for about three years with no issues. > I have not done any sort of regression testing against other Asterisk > features or in configurations other than my own production server. > > > Thanks, > > Graham Mainwaring > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
