-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4368/
-----------------------------------------------------------
Review request for Asterisk Developers.
Bugs: ASTERISK-24719
https://issues.asterisk.org/jira/browse/ASTERISK-24719
Repository: Asterisk
Description
-------
Starting and stopping conference recording more than once causes the
recording channels to be leaked. For v13 the channels also show up in the
CLI "core show channels" output.
* Reworked and simplified the recording channel code to use
ast_bridge_impart() instead of managing the recording thread in the
ConfBridge code. The recording channel's ref handling easily falls into
place and other off nominal code paths get handled better as a result.
Diffs
-----
/branches/11/apps/confbridge/include/confbridge.h 431048
/branches/11/apps/app_confbridge.c 431049
Diff: https://reviewboard.asterisk.org/r/4368/diff/
Testing
-------
With the test:
The confbridge testsuite tests still pass.
Manual testing no longer has the recording channel ref leak.
Thanks,
rmudgett
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
