----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4407/#review14420 -----------------------------------------------------------
2) Util ast_join_delim: don't touch w[x] if x out of bounds of size Should be: 2) Utils.c ast_join_delim: don't touch w[x] if x out of bounds of size /branches/13/main/config.c <https://reviewboard.asterisk.org/r/4407/#comment24938> Should set cfg_hooks = NULL after cleanup. - rmudgett On Feb. 5, 2015, 4:25 p.m., Scott Griepentrog wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4407/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2015, 4:25 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > A collection of small fixes to prevent Valgrind errors for your amusement and > approval: > > 1) Config hooks: a) don't hold extra reference after creation of a hook, b) > cleanup the container on shutdown > > 2) Util ast_join_delim: don't touch w[x] if x out of bounds of size > > 3) res_pjsip sync_task: prevent reference to sync task data struct if it gets > freed after unlocked. > > > Diffs > ----- > > /branches/13/res/res_pjsip.c 431571 > /branches/13/main/utils.c 431571 > /branches/13/main/config.c 431571 > > Diff: https://reviewboard.asterisk.org/r/4407/diff/ > > > Testing > ------- > > In each case Valgrind did not show the same error again after the patch was > added. > > > Thanks, > > Scott Griepentrog > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
