-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4489/
-----------------------------------------------------------
Review request for Asterisk Developers.
Bugs: ASTERISK-24840
https://issues.asterisk.org/jira/browse/ASTERISK-24840
Repository: Asterisk
Description
-------
Make sure that no matter what order the endpoint identifier modules were
loaded, priority is given based on the ones specified in the new global
'endpoint_identifier_order' option.
The original patch for this issue had to be reverted due to some problems it
created (original review: https://reviewboard.asterisk.org/r/4455/).
However, those problems have now been alleviated with the current patch on this
review. Instead of having the associated endpoint identifier name directly
contained on the identifier object (part of the externally exposed struct
definition) the name is now passed in as part of the register function. The old
register function has been left for backwards compatibility or for any modules
that don't need to register with a name.
Diffs
-----
branches/13/res/res_pjsip_endpoint_identifier_user.c 432869
branches/13/res/res_pjsip_endpoint_identifier_ip.c 432869
branches/13/res/res_pjsip_endpoint_identifier_anonymous.c 432869
branches/13/res/res_pjsip/config_global.c 432869
branches/13/res/res_pjsip.c 432869
branches/13/include/asterisk/res_pjsip.h 432869
branches/13/contrib/ast-db-manage/config/versions/45e3f47c6c44_add_pjsip_endpoint_identifier_order.py
432869
branches/13/configs/samples/pjsip.conf.sample 432869
branches/13/CHANGES 432869
Diff: https://reviewboard.asterisk.org/r/4489/diff/
Testing
-------
Ran the testsuite test and it still passed. Modified the test by changing the
order of the identifiers and it failed (as it should have).
Thanks,
Kevin Harwell
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
