> On March 22, 2015, 11:05 p.m., Matt Jordan wrote: > > /asterisk/trunk/tests/channels/pjsip/rpid_immediate/configs/ast1/pjsip.conf, > > lines 5-6 > > <https://reviewboard.asterisk.org/r/4518/diff/1/?file=72703#file72703line5> > > > > I'd only use a single line to break up sections
Removed the extra line between [local-transport] and [my_endpoint](!). The other double blank lines are separating section groups for alice and bob. > On March 22, 2015, 11:05 p.m., Matt Jordan wrote: > > /asterisk/trunk/tests/channels/pjsip/rpid_immediate/configs/ast1/extensions.conf, > > lines 3-6 > > <https://reviewboard.asterisk.org/r/4518/diff/1/?file=72702#file72702line3> > > > > Is there actually a risk of alice not answering? The check is covering bases in case something happens with the call to alice. - rmudgett ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4518/#review14763 ----------------------------------------------------------- On March 20, 2015, 3:48 p.m., rmudgett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4518/ > ----------------------------------------------------------- > > (Updated March 20, 2015, 3:48 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24781 > https://issues.asterisk.org/jira/browse/ASTERISK-24781 > > > Repository: testsuite > > > Description > ------- > > Test the rpid_immediate option when enabled and disabled. > > > Diffs > ----- > > /asterisk/trunk/tests/channels/pjsip/tests.yaml 6539 > /asterisk/trunk/tests/channels/pjsip/rpid_immediate/test-config.yaml > PRE-CREATION > /asterisk/trunk/tests/channels/pjsip/rpid_immediate/configs/ast1/pjsip.conf > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/rpid_immediate/configs/ast1/extensions.conf > PRE-CREATION > > Diff: https://reviewboard.asterisk.org/r/4518/diff/ > > > Testing > ------- > > This is the testsuite test to test the rpid_immediate option added by review: > https://reviewboard.asterisk.org/r/4473/ > > The test passes. > > > Thanks, > > rmudgett > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
