----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4496/#review14784 -----------------------------------------------------------
Ship it! Ship It! - Joshua Colp On March 14, 2015, 3:21 p.m., Matt Jordan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4496/ > ----------------------------------------------------------- > > (Updated March 14, 2015, 3:21 p.m.) > > > Review request for Asterisk Developers and Joshua Colp. > > > Bugs: ASTERISK-24780 > https://issues.asterisk.org/jira/browse/ASTERISK-24780 > > > Repository: Asterisk > > > Description > ------- > > From the issue: > > {quote} > In both xmpp_roster_hook and xmpp_client_create_buddy, it ignores the > XMPP_AUTOREGISTER setting and sets "buddy->subscribe = 1" if there is no > subscription. > > This is a regression as it was already fixed in ASTERISK-14233. It is > extremely inconvenient to have Asterisk send "Greetings! I am the Asterisk > Open Source PBX and I want to subscribe to your presence" to everyone in your > contact list. > > I am sharing my own XMPP account with Asterisk (at a negative priority) and > this needs to be a recognised use case where Asterisk should not do > inappropriate things. > {quote} > > We are indeed ignoring the XMPP_AUTOREGISTER setting. This is due to not > properly copying over the global settings to the client settings. Thanks to > Simon Arlott for providing the patch for this. > > > Diffs > ----- > > /branches/11/res/res_xmpp.c 432991 > > Diff: https://reviewboard.asterisk.org/r/4496/diff/ > > > Testing > ------- > > > Thanks, > > Matt Jordan > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
