----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4510/#review14798 -----------------------------------------------------------
branches/13/apps/app_confbridge.c <https://reviewboard.asterisk.org/r/4510/#comment25391> Missing param doxygen. I think this is also needed in the v11 patch. branches/13/main/bridge_channel.c <https://reviewboard.asterisk.org/r/4510/#comment25392> Remove this comment as it was for the assert that was removed and it isn't true anymore. branches/13/main/bridge_channel.c <https://reviewboard.asterisk.org/r/4510/#comment25393> Just if (digit) is sufficient. If anything, you should assert: ast_assert(0 <= digit) because passing in a negative value is invalid. - rmudgett On March 19, 2015, 4:59 p.m., Kevin Harwell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4510/ > ----------------------------------------------------------- > > (Updated March 19, 2015, 4:59 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24864 > https://issues.asterisk.org/jira/browse/ASTERISK-24864 > > > Repository: Asterisk > > > Description > ------- > > This is the Asterisk 13 version of the following: > https://reviewboard.asterisk.org/r/4477/ > > Attempting to execute DTMF in a confbridge while file playback (prompt, > announcement, etc) is occurring is not allowed. You have to wait until the > sound file has completed before entering DTMF. This patch fixes it so that > app_confbridge now monitors for dtmf key presses during file playback. If a > key is pressed playback stops and it executes the matched menu option. Unlike > the Asterisk 11 patch this version does not re-queue the dtmf frame, but > instead uses an already available function that monitors for dtmf presses > during playback. > > > Diffs > ----- > > branches/13/main/bridge_channel.c 433195 > branches/13/include/asterisk/bridge_channel.h 433195 > branches/13/apps/app_confbridge.c 433195 > > Diff: https://reviewboard.asterisk.org/r/4510/diff/ > > > Testing > ------- > > Manual testing done. Setup a basic conference bridge that allowed both > regular and admin users to enter. Ran through various menu options to make > sure the sound file playback would stop (no longer have to wait) and a new > option was executed when appropriate. Also ran the app_confbridge testsuite > tests to make sure they still passed. > > > Thanks, > > Kevin Harwell > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
