----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4526/#review14855 -----------------------------------------------------------
/branches/13/funcs/func_env.c <https://reviewboard.asterisk.org/r/4526/#comment25463> Note the double closing parens after the first sizeof, i actually finishes the ast_str_append_substr command and then continues with the second sizeof. Not a 100% sure if this is corrected in the right way, but the original doesn't look right either. - Diederik de Groot On March 26, 2015, 6:32 p.m., Diederik de Groot wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4526/ > ----------------------------------------------------------- > > (Updated March 26, 2015, 6:32 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24917 > https://issues.asterisk.org/jira/browse/ASTERISK-24917 > > > Repository: Asterisk > > > Description > ------- > > clang's static analyzer will throw quite a number warnings / errors during > compilation, some of which can be very helpfull in finding corner-case > bugs\nclang compiler warning:-Wunused-value -Wunused-variable > -Wunused-const-variable > > > Diffs > ----- > > /branches/13/utils/extconf.c 433444 > /branches/13/utils/conf2ael.c 433444 > /branches/13/main/security_events.c 433444 > /branches/13/main/features.c 433444 > /branches/13/main/editline/np/strlcpy.c 433444 > /branches/13/main/editline/np/strlcat.c 433444 > /branches/13/main/config.c 433444 > /branches/13/funcs/func_env.c 433444 > /branches/13/codecs/gsm/src/gsm_create.c 433444 > /branches/13/channels/chan_pjsip.c 433444 > /branches/13/cel/cel_sqlite3_custom.c 433444 > /branches/13/apps/app_queue.c 433444 > > Diff: https://reviewboard.asterisk.org/r/4526/diff/ > > > Testing > ------- > > > Thanks, > > Diederik de Groot > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
