----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4543/#review14940 -----------------------------------------------------------
/branches/13/include/asterisk/utils.h <https://reviewboard.asterisk.org/r/4543/#comment25553> I don't have any problem with the actual fix here, but I don't think we should change the parameter name from initval to ctor. In the list of parameters passed to the RAII_VAR macro, initval represents an actual concrete value to assign to the variable specified by vartype/varname. Yes, sometimes that value is returned by a constructor function - but it is often just a value as well. For example: RAII_VAR(struct foo_t *, foo, NULL, ao2_cleanup); On the other hand, the 'dtor' parameter *must* be invokable. It isn't a value - it is a destructor function that is called when varname leaves scope. - Matt Jordan On March 27, 2015, 10:08 a.m., Diederik de Groot wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4543/ > ----------------------------------------------------------- > > (Updated March 27, 2015, 10:08 a.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24917 > https://issues.asterisk.org/jira/browse/ASTERISK-24917 > > > Repository: Asterisk > > > Description > ------- > > RAII-clang reentrancy / Updating variable from inside a _block > > To update the varname variable from inside the cleanup block it needs to be > decorated with "__block" as in: > __block vartype varname = ctor; > > > Diffs > ----- > > /branches/13/include/asterisk/utils.h 433444 > > Diff: https://reviewboard.asterisk.org/r/4543/diff/ > > > Testing > ------- > > > Thanks, > > Diederik de Groot > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
