----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4548/#review14956 -----------------------------------------------------------
Ship it! Tested this for ABI forward/backwards compatibility with DPMA and it passed. - Scott Griepentrog On March 27, 2015, 6:45 p.m., Corey Farrell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4548/ > ----------------------------------------------------------- > > (Updated March 27, 2015, 6:45 p.m.) > > > Review request for Asterisk Developers, rmudgett and Scott Griepentrog. > > > Repository: Asterisk > > > Description > ------- > > When modules are distributed as binaries, they are sometimes built against > the latest Asterisk in a branch, but need to be able to run against any > version within that branch. The recent addition of ast_log_safe can pose a > problem in this situation. The new function is used from utils.h, but the > symbol is not available in older versions. The solution to this is to have > modules just use ast_log for OOM errors. The core will still use > ast_log_safe for OOM errors, so this will protect against infinite logger > recursion. > > > Diffs > ----- > > /branches/11/main/Makefile 433658 > /branches/11/include/asterisk/utils.h 433658 > > Diff: https://reviewboard.asterisk.org/r/4548/diff/ > > > Testing > ------- > > make cdr main utils > > Check object files with 'nm -g' to verify that main/*.o still used > ast_log_safe. Verified that cdr/*.o and utils/*.o did not use ast_log_safe. > > > Thanks, > > Corey Farrell > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
