Matt Jordan has posted comments on this change. Change subject: Add a test for PJSIP t38 with authentication based on normal t38 test The test will start two instances of Asterisk. The first will originate a PJSIP call with authentication to the second using an extension that will run sendFax. The second will receive ......................................................................
Patch Set 2: (5 comments) https://gerrit.asterisk.org/#/c/28/2//COMMIT_MSG Commit Message: Line 7: Add a test for PJSIP t38 with authentication based on normal t38 test : The test will start two instances of Asterisk. The first will originate Place a blank line between the commit summary and the commit body. Line 14: ASTERISK-24933 Add the Reported by: field at least. https://gerrit.asterisk.org/#/c/28/2/tests/fax/pjsip/t38_with_auth/run-test File tests/fax/pjsip/t38_with_auth/run-test: Line 26: """Test class for performing the test. Manages files, originates FAX call, : and monitors a user event to verify that the fax completed successfully on : the sender end of the call. Pydoc comments should always have a single line summary (79 characters) and a description below them, if warranted. This comment applies to all Pydoc comments in this test. Line 68: LOGGER.error("error sending fax through t38:") : LOGGER.error("operation: %s" % (event['operation'],)) : LOGGER.error("status: %s" % (event['status'],)) : LOGGER.error("error: %s" % (event['error'],)) : LOGGER.error("statusstr: %s" % (event['statusstr'],)) Nitpick: capitalization please :-) https://gerrit.asterisk.org/#/c/28/2/tests/fax/pjsip/t38_with_auth/test-config.yaml File tests/fax/pjsip/t38_with_auth/test-config.yaml: Line 9: Use the YAML tag for issues: issues: - jira: 'ASTERISK-24933' -- To view, visit https://gerrit.asterisk.org/28 To unsubscribe, visit https://gerrit.asterisk.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If37cf20857ae3c0b35e0637a0a2cb7e7d6226df6 Gerrit-PatchSet: 2 Gerrit-Project: testsuite Gerrit-Branch: master Gerrit-Owner: Jonathan Rose <[email protected]> Gerrit-Reviewer: Matt Jordan <[email protected]> Gerrit-HasComments: Yes -- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
