> On April 6, 2015, 11:59 a.m., Matt Jordan wrote: > > branches/11/main/ccss.c, lines 816-818 > > <https://reviewboard.asterisk.org/r/4581/diff/2/?file=73569#file73569line816> > > > > Shouldn't this be: > > > > if (sscanf(value, "%30u", &value_ast_uint) != 1) { > > ... > > }
Yeah, this is already fixed in my version. - George ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4581/#review15079 ----------------------------------------------------------- On April 3, 2015, 12:44 p.m., George Joseph wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4581/ > ----------------------------------------------------------- > > (Updated April 3, 2015, 12:44 p.m.) > > > Review request for Asterisk Developers and Scott Griepentrog. > > > Bugs: ASTERISK-24932 > https://issues.asterisk.org/jira/browse/ASTERISK-24932 > > > Repository: Asterisk > > > Description > ------- > > These are fixes for compilation under gcc 5.0... > > chan_sip.c: In parse_request needed to make 'lim' unsigned. > inline_api.h: Needed to add a check for '__GNUC_STDC_INLINE__' to detect C99 > inline semantics (same as clang). > ccss.c: In ast_cc_set_parm, needed to fix weird comparison. > dsp.c: Needed to work around a possible compiler bug. It was > throwing an array-bounds error but neither > sgriepentrog, rmudgett nor I could figure out why. > manager.c: In action_atxfer, needed to correct an array allocation. > > If I can reproduce the possible gcc bug in a short test case, I'll submit it > upstream. > > This patch will go to 11, 13, trunk. > > Reported-by: Jeffrey Ollie > > > Diffs > ----- > > branches/11/main/manager.c 433966 > branches/11/main/dsp.c 433966 > branches/11/main/ccss.c 433966 > branches/11/include/asterisk/inline_api.h 433966 > branches/11/channels/chan_sip.c 433966 > > Diff: https://reviewboard.asterisk.org/r/4581/diff/ > > > Testing > ------- > > Ran unit and testsuite tests. No differences detected. > > > Thanks, > > George Joseph > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
