----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4598/#review15116 -----------------------------------------------------------
Ship it! /trunk/main/dns_test.c <https://reviewboard.asterisk.org/r/4598/#comment25786> moar nitpicking :-) this could be changed to actual_len as well if you were so inclined. - Kevin Harwell On April 7, 2015, 12:49 p.m., Mark Michelson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4598/ > ----------------------------------------------------------- > > (Updated April 7, 2015, 12:49 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > Josh worked on SRV in one branch, and I worked on NAPTR in a separate branch. > Independently we kept coming to realizations that something that one of us > had developed independently would be needed by the other person. We decided > to simply have copies of common functionality in our branches. After merging, > we would perform a refactor to remove duplication. > > This changeset introduces no new DNS functionality. Instead, it takes some > duplicated code and places them into common areas of the DNS core. > > > Diffs > ----- > > /trunk/tests/test_dns_srv.c 434218 > /trunk/tests/test_dns_naptr.c 434218 > /trunk/main/dns_test.c PRE-CREATION > /trunk/main/dns_srv.c 434218 > /trunk/main/dns_naptr.c 434218 > /trunk/main/dns_core.c 434218 > /trunk/include/asterisk/dns_test.h PRE-CREATION > /trunk/include/asterisk/dns_internal.h 434218 > > Diff: https://reviewboard.asterisk.org/r/4598/diff/ > > > Testing > ------- > > All DNS unit tests continue to pass. > > > Thanks, > > Mark Michelson > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
