Ashley Sanders has posted comments on this change. Change subject: stasis: set a channel variable on websocket disconnect error ......................................................................
Patch Set 1: (1 comment) Addressed Mark Michelson's suggestion for refactoring the self.__validate method in observable_object.py. https://gerrit.asterisk.org/#/c/18/1/tests/rest_api/applications/stasisstatus/observable_object.py File tests/rest_api/applications/stasisstatus/observable_object.py: Line 143: def __validate(self, **kwargs): > On the topic of YAGNI, XP co-founder Ron Jeffries has written, "Always impl The next morning, I realized that I misunderstood your comment regarding the way I was using this method. This file underwent several refactorings and at some point, much earlier on, this method body made sense. However, because all of that earlier code turned out to be fat, it was trimmed. And now subsequently this, too, is fat that needs trimming. So, yes. I agree with your contention, and in patch 5, this method body has been refactored to remove unnecessary bloat. In other news, eating crow isn't so bad. It tastes a little bit like a chicken nugget :) -- To view, visit https://gerrit.asterisk.org/18 To unsubscribe, visit https://gerrit.asterisk.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f7dadfd429bd30e9f07a531f47884d8c923fc13 Gerrit-PatchSet: 1 Gerrit-Project: testsuite Gerrit-Branch: master Gerrit-Owner: Ashley Sanders <[email protected]> Gerrit-Reviewer: Ashley Sanders <[email protected]> Gerrit-Reviewer: Mark Michelson <[email protected]> Gerrit-Reviewer: Matt Jordan <[email protected]> Gerrit-HasComments: Yes -- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
