Ashley Sanders has posted comments on this change. Change subject: stasis: set a channel variable on websocket disconnect error ......................................................................
Patch Set 8: (2 comments) Addressed both of Matt Jordan's review feedback comments. https://gerrit.asterisk.org/#/c/18/8/tests/rest_api/applications/stasisstatus/ari_client.py File tests/rest_api/applications/stasisstatus/ari_client.py: Line 94: return wait_for_it() > wait_for_it() does not appear to return anything. On the other hand, self._ I am opting for option #1. There is nothing in the caller of either method where I use a nested 'wait_for_it' method that demands a deferred object be returned. https://gerrit.asterisk.org/#/c/18/8/tests/rest_api/applications/stasisstatus/test-config.yaml File tests/rest_api/applications/stasisstatus/test-config.yaml: Line 31: - Application > Since none of the other application ARI tests use this tag, please remove i My mistake =) I thought that I got the notion from another stasis test but, alas, I am wrong. It has been removed. -- To view, visit https://gerrit.asterisk.org/18 To unsubscribe, visit https://gerrit.asterisk.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f7dadfd429bd30e9f07a531f47884d8c923fc13 Gerrit-PatchSet: 8 Gerrit-Project: testsuite Gerrit-Branch: master Gerrit-Owner: Ashley Sanders <asand...@digium.com> Gerrit-Reviewer: Ashley Sanders <asand...@digium.com> Gerrit-Reviewer: Mark Michelson <mmichel...@digium.com> Gerrit-Reviewer: Matt Jordan <mjor...@digium.com> Gerrit-HasComments: Yes -- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
