----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4587/#review15151 -----------------------------------------------------------
branches/13/configs/samples/pjsip.conf.sample <https://reviewboard.asterisk.org/r/4587/#comment25806> We need to pick a measurement and stick with it. The qualify_frequency option is in seconds. The qualify_timeout option is in milliseconds. As a user that would be confusing. branches/13/res/res_pjsip/pjsip_configuration.c <https://reviewboard.asterisk.org/r/4587/#comment25809> This is abuse of RAII_VAR :P it's not needed. branches/13/res/res_pjsip/pjsip_configuration.c <https://reviewboard.asterisk.org/r/4587/#comment25810> You have a leak here. ao2_iterator isn't destroyed. branches/13/res/res_pjsip/pjsip_options.c <https://reviewboard.asterisk.org/r/4587/#comment25807> You *CAN NOT* do this. Sorcery objects are immutable. You have to create a new one and then update using it. branches/13/res/res_pjsip/pjsip_options.c <https://reviewboard.asterisk.org/r/4587/#comment25808> Same here. - Joshua Colp On April 7, 2015, 11:54 p.m., George Joseph wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4587/ > ----------------------------------------------------------- > > (Updated April 7, 2015, 11:54 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24863 > https://issues.asterisk.org/jira/browse/ASTERISK-24863 > > > Repository: Asterisk > > > Description > ------- > > This is the second follow-on to https://reviewboard.asterisk.org/r/4572/ and > the discussion at > http://lists.digium.com/pipermail/asterisk-dev/2015-March/073921.html > > The basic issues are that changes in contact status don't cause events to be > emitted for the associated endpoint. Only dynamic contact add/delete actions > update the endpoint. Also, the qualify timeout is fixed by pjsip at 32 > seconds which is a long time. > > This patch makes use of the new transaction timeout feature in r4585 and > provides the following capabilities... > > 1. A new aor/contact variable 'qualify_timeout' has been added that allows > the user to specify the maximum time in milliseconds to wait for a response > to an OPTIONS mesasge. The default is 3000ms. When the timer expires, the > contact is marked unavailable. > > 2. Contact status changes are now propagated up to the endpoint as > follows... When any contact is 'Available', the endpoint is marked as > 'Reachable'. When all contacts are 'Unavailable', the endpoint is marked as > 'Unreachable'. The existing endpoint events are generated appropriately. > > > Diffs > ----- > > branches/13/res/res_pjsip/pjsip_options.c 433967 > branches/13/res/res_pjsip/pjsip_configuration.c 433967 > branches/13/res/res_pjsip/location.c 433967 > branches/13/res/res_pjsip.c 433967 > branches/13/main/endpoints.c 433967 > branches/13/include/asterisk/res_pjsip.h 433967 > branches/13/include/asterisk/endpoints.h 433967 > > branches/13/contrib/ast-db-manage/config/versions/2256a84ca226_add_pjsip_qualify_timeout.py > PRE-CREATION > branches/13/configs/samples/pjsip.conf.sample 433967 > > Diff: https://reviewboard.asterisk.org/r/4587/diff/ > > > Testing > ------- > > Existing tests are unchanged. I'm working on new testsuite tests to check > the new functionality. > > Tested-by: Dmitriy Serov > > > Thanks, > > George Joseph > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
