Hi, I submitted that change, as we have need for not the 'no' and the 'never' cases on different devices/trunks etc, and before the patch they were almost the same.
I completely agree with the above suggestion from Kevin. I always set "progressinband" manually for all of my device definitions, so had never realised that the patch was changing the normal/default behaviour. Regards, Steve On Wed, 8 Apr 2015 at 18:00 Kevin Harwell <[email protected]> wrote: > Greetings, > > A few months ago an issue [1] was reported that when the "progressinband" > option found in chan_sip was set to "never" it was not working correctly in > some scenarios. A fix for the issue was committed [2]. However, the fix had > a side effect of changing the scope of "never" somewhat and since "never" > is the default this can potentially cause some confusion or unexpected > behavior when upgrading. > > It's believed that changing the default from "never" to "no" would be more > appropriate for most users as then "progressinband" would default to > working similar to how it was before. > > Thoughts on this? Leave it defaulting to "never"? Changing it to "no" > would be fine? > > [1] https://issues.asterisk.org/jira/browse/ASTERISK-23972 > [2] https://reviewboard.asterisk.org/r/3700 > > -- > > Kevin Harwell > Digium, Inc. | Software Developer > 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA > Check us out at: http://digium.com & http://asterisk.org > > -- > _____________________________________________________________________ > -- Bandwidth and Colocation Provided by http://www.api-digital.com -- > > asterisk-dev mailing list > To UNSUBSCRIBE or update options visit: > http://lists.digium.com/mailman/listinfo/asterisk-dev
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
