-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4589/
-----------------------------------------------------------
(Updated April 11, 2015, 10:11 a.m.)
Status
------
This change has been marked as submitted.
Review request for Asterisk Developers.
Changes
-------
Committed in revision 434688
Bugs: ASTERISK-24928
https://issues.asterisk.org/jira/browse/ASTERISK-24928
Repository: Asterisk
Description
-------
Initialize "udptl->far_max_datagram" in t38_initialize_session() with a default
value or a value provided
in pjsip.conf (t38_udptl_maxdatagram).
Without this far_max_datagram remains -1 if the remote endpoint does not
provide the MediaAttribute T38FaxMaxDatagram
in it's SIP INVITE SDP. This will result in the INVITE being rejected.
Diffs
-----
/branches/13/res/res_pjsip_t38.c 433967
Diff: https://reviewboard.asterisk.org/r/4589/diff/
Testing
-------
I have tested the patch with the following setup. The Asterisk is acting as
relay.
The external T.38 gateway is at our ISP. The internal gateway is a Cisco SPA112.
The ISP’s gateway does not include T38FaxMaxDatagram in SDPs.
The test cases included:
- No t38_udptl_maxdatagram in pjsip.conf
o Faxes in both directions with "normal" SDPs (all INVITEs created by Cisco),
o Outbound fax w/o T38FaxMaxDatagram in SDP,
- t38_udptl_maxdatagram defined in pjsip.conf for both endpoints
o Faxes in both directions with "normal" SDPs (all INVITEs created by Cisco).
All tests were completed successfully.
Thanks,
Juergen Spies
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
