Matt Jordan has posted comments on this change. Change subject: Add .gitignore and .gitreview files ......................................................................
Patch Set 2: (2 comments) https://gerrit.asterisk.org/#/c/42/2/.gitignore File .gitignore: Line 21: addons/mp3 > I personally think it's nicer to use .gitignore files in subdirectories. S To address George's comment: I'm good either way. https://gerrit.asterisk.org/#/c/42/2//COMMIT_MSG Commit Message: Line 15: Tested-by: George Joseph > I think it would be good to move to using the same format for other git hea I'd be fine with that, but we'll need to update the wiki/commit message script as well. We should be able to extract that quite easily from JIRA - in fact, it'd probably be helpful to just have a script that returns that and the CLA License numbers as appropriate. /me makes a note to do that. -- To view, visit https://gerrit.asterisk.org/42 To unsubscribe, visit https://gerrit.asterisk.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I842a1588ff27d8a0189f12d597f0a7af033d6c69 Gerrit-PatchSet: 2 Gerrit-Project: asterisk Gerrit-Branch: master Gerrit-Owner: George Joseph <george.jos...@fairview5.com> Gerrit-Reviewer: Corey Farrell <g...@cfware.com> Gerrit-Reviewer: George Joseph <george.jos...@fairview5.com> Gerrit-Reviewer: Matt Jordan <mjor...@digium.com> Gerrit-Reviewer: Russell Bryant <russ...@russellbryant.net> Gerrit-HasComments: Yes -- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
