Matt Jordan has posted comments on this change. Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro ......................................................................
Patch Set 3: (3 comments) https://gerrit.asterisk.org/#/c/54/3/include/asterisk.h File include/asterisk.h: Line 164: void ast_register_file(const char *file); > Given that this is meant for use through a macro only, shouldn't it be __as Works for me. https://gerrit.asterisk.org/#/c/54/3/main/manager.c File main/manager.c: Line 5998: snprintf(cut, (sizeof(filename) - strlen(filename)) - 1, ".c"); : ast_debug(1, "**** ModuleCheck .c file %s\n", filename); > Since we're no longer checking the source file registration I think this sh Good point - removed. https://gerrit.asterisk.org/#/c/54/3/utils/check_expr.c File utils/check_expr.c: Line 155: //void ast_register_file(const char *file, const char *version); : //void ast_unregister_file(const char *file); > Delete.. I look forward to the day when we can delete all of the utils/ directory :-P -- To view, visit https://gerrit.asterisk.org/54 To unsubscribe, visit https://gerrit.asterisk.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id146f24e9d968dccd64cb09dbfa1da3d9ac719f6 Gerrit-PatchSet: 3 Gerrit-Project: asterisk Gerrit-Branch: master Gerrit-Owner: Matt Jordan <[email protected]> Gerrit-Reviewer: Corey Farrell <[email protected]> Gerrit-Reviewer: Matt Jordan <[email protected]> Gerrit-HasComments: Yes -- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
