Mark Michelson has posted comments on this change. Change subject: digium_jira: Refactor module to wrap the Atlassian JIRA REST client ......................................................................
Patch Set 2: (2 comments) https://gerrit.asterisk.org/#/c/69/2/digium_jira.py File digium_jira.py: Line 16: try: : jira_cache = open(os.path.expanduser('~') + "/.jira_login", "r") : jira_user = jira_cache.readline().strip() : jira_pw = jira_cache.readline().strip() : jira_cache.close() : return (jira_user, jira_pw) : except IOError: : pass Python developers are encouraged to use the "with" keyword for file I/O since it automatically will close the file properly even if an exception occurs while operating on the file. Line 25: # Didn't get auth deatils from file, try interactive instead. s/deatils/details/ -- To view, visit https://gerrit.asterisk.org/69 To unsubscribe, visit https://gerrit.asterisk.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69932dd472aef4290af97e809ce6b9ec9c25b39d Gerrit-PatchSet: 2 Gerrit-Project: repotools Gerrit-Branch: master Gerrit-Owner: Matt Jordan <[email protected]> Gerrit-Reviewer: Jared K. Smith <[email protected]> Gerrit-Reviewer: Mark Michelson <[email protected]> Gerrit-HasComments: Yes -- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
