-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4580/
-----------------------------------------------------------
(Updated April 14, 2015, 3:48 p.m.)
Status
------
This change has been discarded.
Review request for Asterisk Developers.
Bugs: ASTERISK-13271
https://issues.asterisk.org/jira/browse/ASTERISK-13271
Repository: Asterisk
Description
-------
The Makefile claims that you can set default menuselect options by creating
~/.asterisk.makeopts or /etc/asterisk.makeopts, but they are never read. The
rule for menuselect.makeopts is only allowed to run if the active target is
'menuselect', but the menuselect target doesn't depend on menuselect.makeopts.
A dot (wildcard character) was added so the rule will be active for the targets
that cause it to run: nmenuselect, cmenuselect, and gmenuselect.
When I first enabled this it caused ~/.asterisk.makeopts to overwrite
./menuselect.makeopts every time I ran 'make menuselect', so I modified the
Makefile to only consider the file in $HOME and /etc when ./menuselect.makeopts
doesn't exist.
Thoughts:
* Having two files ($HOME and /etc) at the same time really doesn't make sense
to me, seems like it would be better to use only the "most local" file.
* As far as I can tell this has never worked in any currently supported
version. I see this as a "new for the second time feature", not a bug fix.
I'm thinking trunk only. If anyone disagrees let me know.
Diffs
-----
/trunk/Makefile 433966
Diff: https://reviewboard.asterisk.org/r/4580/diff/
Testing
-------
Repeatedly ran 'make menuselect' with and without files in the 3 locations. No
one else has tested this.
Thanks,
Corey Farrell
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
