On 24 Apr 2015, at 15:42, Russell Bryant <russ...@russellbryant.net> wrote:
> On Fri, Apr 24, 2015 at 8:31 AM, Joshua Colp <jc...@digium.com> wrote:
> Olle E. Johansson wrote:
> Playing around following Matt's wiki page on gerrit usage, I created
> a team branch and did two commits. When pushing it with "git review
> {branch}" only the last commit shows up.
>
> Is that the way it's supposed to be? I thought the whole branch was
> the review subject, not just a single commit.
>
> Gerrit works on a single commit (what it refers to as a patch set) that you
> want included into a specific branch. As a result you need to squash all
> commits into a single one, and if review feedback warrants further changes
> they also need to be squashed back into a single commit with the original
> changes. The single commit you post for review is what is reviewed and merged
> into the branch.
>
> Gerrit can also work on a patch series, and tracks dependencies between those
> patches.
Define "patch series" - how do you commit a series of patches for review?
/O
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
