On Fri, Jun 30, 2023 at 9:36 AM Andrew Latham <lath...@gmail.com> wrote:
> George > > I just had an idea. We could disable the github plugin by not setting a > repo and then just add the links to a custom footer or `About` page. Just a > thought > Actually, changing that plugin to point to the actual asterisk repo makes more sense and seems to show the correct release, number of stars and forks. > > On Fri, Jun 30, 2023 at 9:33 AM Andrew Latham <lath...@gmail.com> wrote: > >> Ack, thanks George >> >> * As best I can tell in the JS [1] it needs a release to generate the >> version. I do agree with you that there is no real need for releases. >> However to enable the JS to work a release may be required. >> * I can see how the double Asterisk logos at the bottom would be >> confusing. I just get a cringe factor when I see the wordpress logo and >> that is just a me thing. >> >> 1. >> https://github.com/squidfunk/mkdocs-material/blob/55fb2e335e04df5b206f2058ba4b706d930b496f/src/assets/javascripts/components/source/facts/github/index.ts#L67C1-L75 >> >> On Fri, Jun 30, 2023 at 5:23 AM George Joseph <gjos...@sangoma.com> >> wrote: >> >>> >>> >>> On Thu, Jun 29, 2023 at 2:06 PM Andrew Latham <lath...@gmail.com> wrote: >>> >>>> Good Work George and crew. It looks really good, it is snappy, looks >>>> nice on mobile. >>>> >>> >>> Thanks! >>> >>> >>>> >>>> All boxes checked!!! >>>> >>>> Nits.... >>>> >>>> 1. I get a 404 on >>>> https://api.github.com/repos/asterisk/documentation/releases/latest >>>> because there is no release yet I guess >>>> >>> >>> Correct. We're not going to do actual releases here because the site is >>> live off the gh-pages branch and whatever is in the main branch. Do you >>> think we need to? >>> >>> >>>> 2. I am thinking the Asterisk Logo would be good at the bottom instead >>>> of the wordpress icon for the blog. Thinking outloud >>>> >>> >>> Then it'd look no different than the website icon. Maybe we can make >>> the background asterisk-orange or something but keep the wordpress logo. >>> >>> >>>> >>>> On Thu, Jun 29, 2023 at 1:14 PM George Joseph <gjos...@sangoma.com> >>>> wrote: >>>> >>>>> I think we're at a point where the new documentation site can go >>>>> live. The dynamic documentation is integrated and the README file has >>>>> been >>>>> expanded greatly with information on how the site is built and how you can >>>>> build it yourself. >>>>> >>>>> Please give it a final look: https://docs.asterisk.org >>>>> >>>>> -- >>>>> George Joseph >>>>> Asterisk Software Developer >>>>> Sangoma Technologies >>>>> Check us out at www.sangoma.com and www.asterisk.org >>>>> -- >>>>> _____________________________________________________________________ >>>>> -- Bandwidth and Colocation Provided by http://www.api-digital.com -- >>>>> >>>>> asterisk-dev mailing list >>>>> To UNSUBSCRIBE or update options visit: >>>>> http://lists.digium.com/mailman/listinfo/asterisk-dev >>>> >>>> >>>> >>>> -- >>>> - Andrew "lathama" Latham - >>>> -- >>>> _____________________________________________________________________ >>>> -- Bandwidth and Colocation Provided by http://www.api-digital.com -- >>>> >>>> asterisk-dev mailing list >>>> To UNSUBSCRIBE or update options visit: >>>> http://lists.digium.com/mailman/listinfo/asterisk-dev >>> >>> -- >>> _____________________________________________________________________ >>> -- Bandwidth and Colocation Provided by http://www.api-digital.com -- >>> >>> asterisk-dev mailing list >>> To UNSUBSCRIBE or update options visit: >>> http://lists.digium.com/mailman/listinfo/asterisk-dev >> >> >> >> -- >> - Andrew "lathama" Latham - >> > > > -- > - Andrew "lathama" Latham - > -- > _____________________________________________________________________ > -- Bandwidth and Colocation Provided by http://www.api-digital.com -- > > asterisk-dev mailing list > To UNSUBSCRIBE or update options visit: > http://lists.digium.com/mailman/listinfo/asterisk-dev
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
