Hey Matt, I will run this by pari and double check, but here is a patch to try that will discard a
bad parsed macro.

(attached)

-bk

Matt Sales wrote:
Sure.

On Wed, Oct 15, 2008 at 4:46 PM, bkruse <[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>> wrote:


    Great!

    That helps a lot.

    I will try to look into this and keep you updated. Would you mind
    trying
    a patch?

    Thanks,

    -Brandon

    Matt Sales wrote:
    > Yes have updated multiple times.  Have turned debugging on and
    get the
    > following:
    >
    > ErrorCode / LineNumber:  2217
    > Error:  t1 is null
    > location is
    http://<myhostname>:8088/asterisk/static/config/js/pbx.js
    >
    > I click Ok to that error then I get:
    >
    > Ping Request:  INVALID SESSION
    > Click OK to reload
    >
    > On Tue, Oct 14, 2008 at 4:21 PM, bkruse <[EMAIL PROTECTED]
    <mailto:[EMAIL PROTECTED]>
    > <mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>>> wrote:
    >
    >
    >     Did you update?
    >
    >     Also, key thing, edit index.html (after you update to 2.0)
    and set
    >     DEBUG, true instead of false.
    >
    >     This will give you a window and an error message, that will
    be useful,
    >     and I can fix.
    >
    >     Voila! (no pun intended)
    >
    >     -bk
    >
    >     Matt Sales wrote:
    >     > I still have this problem.  I reverted back to the 1.0 GUI
    and it
    >     > works.  I updated to 2.0 again and does the same thing.
     Prompts me
    >     > that it's taking a backup, I click OK, then nothing.
    >     >
    >     > On Tue, Sep 30, 2008 at 10:26 AM, Matt Sales
    <[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>
    >     <mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>>
    >     > <mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>
    <mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>>>> wrote:
    >     >
    >     >     Ok i updated from svn and it's still not working.  I'm not
    >     getting
    >     >     errors.  Just get the pop up about the configuration being
    >     update
    >     >     and a backup.  I click ok to the pop up and i get
    nothing.  I'm
    >     >     not getting any errors.  I'm running FireFox 3.0.3.
    <http://3.0.3.>
    >     <http://3.0.3.>
    >     >     <http://3.0.3.>  I also tested it in IE 7 and mobile
    FireFox
    >     with
    >     >     the same results.
    >     >
    >     >     Thanks
    >     >
    >     >
    >     >     On Mon, Sep 29, 2008 at 5:19 PM, bkruse
    <[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>
    >     <mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>>
    >     >     <mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>
    <mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>>>> wrote:
    >     >
    >     >
    >     >         Hey Matt,
    >     >
    >     >         Pari just did some work with backups, can you try to
    >     update again?
    >     >
    >     >         Also, what browser are you using, do you see any
    javascript
    >     >         errors?
    >     >
    >     >         Thanks,
    >     >
    >     >         -Brandon
    >     >
    >     >         Matt Sales wrote:
    >     >         > I just updated my 2.0 GUI to svn 3910.  Now when
    I log
    >     in it
    >     >         tells me
    >     >         > that my configuration is being upgraded and that a
    >     backup is
    >     >         being
    >     >         > done.  When I click OK to the popup nothing happens.
    >     I do
    >     >         not get
    >     >         > redirected to the GUI.  I just sit at a blank
    page.  I
    >     >         verified that
    >     >         > the it is putting the backup in
    >     >         /var/lib/asterisk/gui_backups.  Anyone
    >     >         > with any ideas?
    >     >         >
    >     >
> ------------------------------------------------------------------------
    >     >         >
    >     >         > _______________________________________________
    >     >         > --Bandwidth and Colocation Provided by
    >     >         http://www.api-digital.com--
    >     >         >
    >     >         > asterisk-gui mailing list
    >     >         > To UNSUBSCRIBE or update options visit:
> > > http://lists.digium.com/mailman/listinfo/asterisk-gui
    >     >
    >     >
    >     >         _______________________________________________
    >     >         --Bandwidth and Colocation Provided by
    >     >         http://www.api-digital.com--
    >     >
    >     >         asterisk-gui mailing list
    >     >         To UNSUBSCRIBE or update options visit:
> > http://lists.digium.com/mailman/listinfo/asterisk-gui
    >     >
    >     >
    >     >
    >     >
> ------------------------------------------------------------------------
    >     >
    >     > _______________________________________________
    >     > --Bandwidth and Colocation Provided by
    http://www.api-digital.com--
    >     >
    >     > asterisk-gui mailing list
    >     > To UNSUBSCRIBE or update options visit:
    >     >    http://lists.digium.com/mailman/listinfo/asterisk-gui
    >
    >
    >     _______________________________________________
    >     --Bandwidth and Colocation Provided by
    http://www.api-digital.com--
    >
    >     asterisk-gui mailing list
    >     To UNSUBSCRIBE or update options visit:
    >       http://lists.digium.com/mailman/listinfo/asterisk-gui
    >
    >
    >
    ------------------------------------------------------------------------
    >
    > _______________________________________________
    > --Bandwidth and Colocation Provided by http://www.api-digital.com--
    >
    > asterisk-gui mailing list
    > To UNSUBSCRIBE or update options visit:
    >    http://lists.digium.com/mailman/listinfo/asterisk-gui


    _______________________________________________
    --Bandwidth and Colocation Provided by http://www.api-digital.com--

    asterisk-gui mailing list
    To UNSUBSCRIBE or update options visit:
      http://lists.digium.com/mailman/listinfo/asterisk-gui


------------------------------------------------------------------------

_______________________________________________
--Bandwidth and Colocation Provided by http://www.api-digital.com--

asterisk-gui mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-gui

Index: config/js/pbx.js
===================================================================
--- config/js/pbx.js	(revision 3967)
+++ config/js/pbx.js	(working copy)
@@ -2208,6 +2208,9 @@
 						var pattern = ASTGUI.parseContextLine.getExten( line );
 						var macroargs = ASTGUI.parseContextLine.getArgs( line ); // macroname = macroargs[0] ;
 						var t1 = ASTGUI.parseContextLine.parseTrunkDialArgument( macroargs[1] ) ; // t1.name (trunkname), t1.prepend, t1.stripx
+						if (!t1) /* Invalid Macro to Parse */ {
+							return;
+						}
 						var tmp_index = this_context.indexOfLike( 'comment=' + pattern + ',' );
 						var clr_name = ( tmp_index == -1 ) ? pattern : this_context[tmp_index].split(',')[2] ;
 		
_______________________________________________
--Bandwidth and Colocation Provided by http://www.api-digital.com--

asterisk-gui mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-gui

Reply via email to