On 12-03-06 05:03 PM, Jason Parker wrote:
On 03/06/2012 03:44 PM, Karl Fife wrote:
It's not a question of whether the default directory permissions are
appropriate. I agree with those.
What we're talking about here is what happens during updates to an existing
directory. I can't see any rationale for changing the group permissions. If the
group permissions differ from the installation defaults, it is because the
sysadmin needed them to be different in order to implement one or more methods
of extensibility / interoperability that make Asterisk so powerful.
Absolutely, it would make sense for the installer to check to be sure it has
SUFFICIENT permissions to operate properly, but it is a huge leap of faith to
assume that it's appropriate to simply delete certain group permissions. Users
only in the owner's group if they belong there, no??
The upshot is that ever since upgrading to 1.8 we have to re-re-re-reset the
group directory permissions to make things work, and that just seems insane to
me if that is a design choice, not a regression.
-Karl
It should only set them if the directory does not exist. If it's changing them,
something is very seriously broken.
This is a result of changing from
$ mkdir -p /etc/asterisk
to
$ install -d /etc/asterisk
Install will blindly overwrite existing permissions if the directory
already exists. When I did the initial patch, I added logic to check if
the directory already exists on the file system, if so, skip re-creating
the directory. I even noted this issue on reviewboard[1], however it
was never implemented.
[1] https://reviewboard.asterisk.org/r/654/#review2370
--
Paul Belanger
Digium, Inc. | Software Developer
twitter: pabelanger | IRC: pabelanger (Freenode)
Check us out at: http://digium.com & http://asterisk.org
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
New to Asterisk? Join us for a live introductory webinar every Thurs:
http://www.asterisk.org/hello
asterisk-users mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-users
