Michal Kazior <[email protected]> writes:
> Some copy engine structures are target specific
> and are uploaded to the device during
> init/configuration.
>
> This also cleans up a bit diag_mem_read/write
> implicit byteswap mess leaving only
> diag_access_read/write with an implicit endianess
> byteswap.
>
> Signed-off-by: Michal Kazior <[email protected]>
[...]
> @@ -567,8 +562,17 @@ static int ath10k_pci_diag_read_access(struct ath10k
> *ar, u32 address,
> u32 *data)
> {
> /* Assume range doesn't cross this boundary */
> - if (address >= DRAM_BASE_ADDRESS)
> - return ath10k_pci_diag_read_mem(ar, address, data, sizeof(u32));
> + if (address >= DRAM_BASE_ADDRESS) {
> + __le32 val;
> + int ret;
For simplicity I would prefer to have variable declaration in the
beginning of the function.
--
Kalle Valo
_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
