Michal Kazior <[email protected]> writes: > On 8 August 2014 12:45, Kalle Valo <[email protected]> wrote: >> Michal Kazior <[email protected]> writes: >> >>> The soc powersave was disabled by default. It >>> never was fully tested. Some hw apparently had >>> problems with it and the implementation itself had >>> a possible race. >>> >>> Just remove the refcounting and simply wake up the >>> device when probing and put to sleep when >>> removing. >>> >>> Signed-off-by: Michal Kazior <[email protected]> >> >> This one introduced new warnings: >> >> drivers/net/wireless/ath/ath10k/pci.c:646:5: warning: symbol >> 'ath10k_pci_wake' was not declared. Should it be static? >> drivers/net/wireless/ath/ath10k/pci.c:653:6: warning: symbol >> 'ath10k_pci_sleep' was not declared. Should it be static? > > I didn't catch this for some reason. Can you share how you run > checkpatch, please?
I think these are coming from sparse, in essence I run this: make drivers/net/wireless/ath/ath10k/ C=2 CF="-D__CHECK_ENDIAN__" Which reminds me that I should add -D__CHECK_ENDIAN__ to the makefile. -- Kalle Valo _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
