Ben Greear <[email protected]> writes:
> On 08/08/2014 01:28 PM, Kalle Valo wrote:
>
>> +
>> + getnstimeofday(×tamp);
>> + dump_data->tv_sec = timestamp.tv_sec;
>> + dump_data->tv_nsec = timestamp.tv_nsec;
>
> I wonder if we should take timestamp at crash time instead of
> crash-dump-gather time?
Good point, we definitely should. I'll change.
>> int ath10k_debug_create(struct ath10k *ar)
>> {
>> + ar->debug.fw_crash_data = vzalloc(sizeof(ar->debug.fw_crash_data));
>> + if (!ar->debug.fw_crash_data)
>> + return -ENOMEM;
>> +
>
> That sizeof looks quite wrong.
Ouch, good catch! Will fix.
--
Kalle Valo
_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
