On 09/24/2014 12:51 AM, Michal Kazior wrote:
On 24 September 2014 02:26, <[email protected]> wrote: [...]+static struct ieee80211_sta_vht_cap ath10k_create_vht_cap(struct ath10k *ar, + bool use_cfg_chains) { struct ieee80211_sta_vht_cap vht_cap = {0}; u16 mcs_map; int i; + int nrf = ar->num_rf_chains; + + if (use_cfg_chains && ar->cfg_tx_chainmask) + nrf = get_nss_from_chainmask(ar->cfg_tx_chainmask);Is use_cfg_chains really necessary here? Is setting tx/rx chainmask to 0x0 make any sense at all? Shouldn't we deny it or make it fallback to the supported tx/rx chainmask values?
It would cause the logic to flip back to the defaults, so seems mildly useful. I'm not sure upper layers would ever let it be < 1 though. Thanks, Ben
Michał
-- Ben Greear <[email protected]> Candela Technologies Inc http://www.candelatech.com _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
