Joe Perches <[email protected]> writes: > On Mon, 2014-09-29 at 14:49 +0300, Kalle Valo wrote: >> Hi Joe, >> >> I have a problem with checkpatch. On ath10k we have this function: >> >> static inline struct ath10k_skb_cb *ATH10K_SKB_CB(struct sk_buff *skb) >> { >> BUILD_BUG_ON(sizeof(struct ath10k_skb_cb) > >> IEEE80211_TX_INFO_DRIVER_DATA_SIZE); >> return (struct ath10k_skb_cb *)&IEEE80211_SKB_CB(skb)->driver_data; >> } >> >> And the BUILD_BUG_ON triggers this warning: >> >> drivers/net/wireless/ath/ath10k/core.h:85: CHECK: No space is necessary >> after a cast >> >> Any advice how to handle that? > > It's a checkpatch false positive that could be fixed. > > It needs something like another test to look for > sizeof(type) as not a cast and more arithmetic/comparison > uses. > > Maybe you can test this?
It works, thank you! Tested-by: Kalle Valo <[email protected]> -- Kalle Valo _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
