On 13 May 2016 at 17:23, Guenther Kelleter <[email protected]> wrote: [...] > If I remove the following 2 lines from drivers/net/wireless/ath/ath10k/mac.c, > set_key succeeds! > > if (!test_bit(ATH10K_FLAG_RAW_MODE, &ar->dev_flags)) > ieee80211_hw_set(ar->hw, SW_CRYPTO_CONTROL);
I think this is buggy in the first place. It should look at ATH10K_FLAG_HW_CRYPTO_DISABLED flag instead of RAW_MODE. > i.e. not setting flag SW_CRYPTO_CONTROL fixes it (apparently). > > This was introduced in linux commit ccec9038c7217e537f5ae5e3ac5af8293a21bbfd > "ath10k: enable raw encap mode and software crypto engine". > > > Can someone shed some light on this crazy stuff? > Is it bad to disable SW_CRYPTO_CONTROL for ath10k? Or does this break crypto? Some cases require software assisted crypto. Michał _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
