I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]> Signed-off-by: Baole Ni <[email protected]> --- drivers/net/wireless/ath/ath10k/core.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c index 49af624..9e42274 100644 --- a/drivers/net/wireless/ath/ath10k/core.c +++ b/drivers/net/wireless/ath/ath10k/core.c @@ -36,11 +36,11 @@ static bool uart_print; static bool skip_otp; static bool rawmode; -module_param_named(debug_mask, ath10k_debug_mask, uint, 0644); -module_param_named(cryptmode, ath10k_cryptmode_param, uint, 0644); -module_param(uart_print, bool, 0644); -module_param(skip_otp, bool, 0644); -module_param(rawmode, bool, 0644); +module_param_named(debug_mask, ath10k_debug_mask, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); +module_param_named(cryptmode, ath10k_cryptmode_param, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); +module_param(uart_print, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); +module_param(skip_otp, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); +module_param(rawmode, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(debug_mask, "Debugging mask"); MODULE_PARM_DESC(uart_print, "Uart target debugging"); -- 2.9.2 _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
