Brian Norris <[email protected]> writes: > + Rob > > On Tue, Jun 05, 2018 at 06:06:16PM +0530, Govind Singh wrote: >> Add device tree binding documentation details of msa >> memory region for ath10k qmi client for SDM845/APQ8098 >> SoC into "qcom,ath10k.txt". >> >> Signed-off-by: Govind Singh <[email protected]> >> --- >> .../devicetree/bindings/net/wireless/qcom,ath10k.txt | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt >> b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt >> index 7fd4e8ce4149..0efc47f4ba34 100644 >> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt >> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt >> @@ -56,6 +56,8 @@ Optional properties: >> the length can vary between hw versions. >> - <supply-name>-supply: handle to the regulator device tree node >> optional "supply-name" is "vdd-0.8-cx-mx". >> +- msa-fixed-region: phandle, specifier to children of reserved MSA memory. > > As in reserved-memory/reserved-memory.txt? Might refer to that doc here. > Or is this some other kind of reserved memory? > > If the former, it's normally called just "memory-region", although > that does seem somewhat non-descriptive... > >> +- msa-size: MSA memory size for fw internal use. > > Do you really need both of these? It seems like your code uses one or > the other, not both. In which case, this is not a very good description, > because it sounds like they would go together. > > Also, if you're not using standard/generic properties (e.g., the > aforementioned "memory-region" binding), you typically should use a > vendor prefix, like "qcom,msa-size".
Devicetree folks, any comments? I would like to apply this via my ath.git tree but need help with the review. Full patch here: https://patchwork.kernel.org/patch/10448169/ -- Kalle Valo _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
