The messages below about iounmap are for the function ath11k_qmi_load_bdf
in qmi.c.  There are three occurrences of goto out that need to jump to
the iounmap above the out: label.

The message about the lock is about the goto fallback on line 4103.
Should the spinlock be unlocked here?

The message about unsigned in dp_tx.c is because the variable
ring_entry_sz is declared as u32 (line 561).

julia

---------- Forwarded message ----------
Date: Fri, 8 Mar 2019 05:28:10 +0800
From: kbuild test robot <l...@intel.com>
To: kbu...@01.org
Cc: Julia Lawall <julia.law...@lip6.fr>
Subject: [ath6kl:ath11k-bringup 3/42]
    drivers/net/wireless/ath/ath11k/qmi.c:1989:1-7: ERROR: missing iounmap;
    ioremap on line 1935 and execution via conditional on line 1965

CC: kbuild-...@01.org
CC: ath10k@lists.infradead.org
TO: Kalle Valo <kv...@codeaurora.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git 
ath11k-bringup
head:   e7daa3ec639f390e383dae0db9e6b143bcc7b5bc
commit: 258bbf525e652e244aa8b2331f55fda573fbe926 [3/42] ath11k: add driver
:::::: branch date: 5 hours ago
:::::: commit date: 4 weeks ago

>> drivers/net/wireless/ath/ath11k/qmi.c:1989:1-7: ERROR: missing iounmap; 
>> ioremap on line 1935 and execution via conditional on line 1965
   drivers/net/wireless/ath/ath11k/qmi.c:1989:1-7: ERROR: missing iounmap; 
ioremap on line 1935 and execution via conditional on line 1971
   drivers/net/wireless/ath/ath11k/qmi.c:1989:1-7: ERROR: missing iounmap; 
ioremap on line 1935 and execution via conditional on line 1977
--
>> drivers/net/wireless/ath/ath11k/dp_rx.c:977:6-15: ERROR: iterator variable 
>> bound on line 976 cannot be NULL
--
>> drivers/net/wireless/ath/ath11k/wmi.c:4140:1-7: preceding lock on line 4088
--
>> drivers/net/wireless/ath/ath11k/dp_rx.c:278:16-22: ERROR: application of 
>> sizeof to pointer
--
>> drivers/net/wireless/ath/ath11k/mac.c:711:5-8: Unneeded variable: "ret". 
>> Return "0" on line 719
   drivers/net/wireless/ath/ath11k/mac.c:418:5-11: Unneeded variable: "status". 
Return "0" on line 451
--
>> drivers/net/wireless/ath/ath11k/mac.c:3274:2-3: Unneeded semicolon
--
>> drivers/net/wireless/ath/ath11k/dp_tx.c:641:5-18: WARNING: Unsigned 
>> expression compared with zero: ring_entry_sz < 0

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

Reply via email to