> -----Original Message-----
> From: ath10k <[email protected]> On Behalf Of Nicolas
> Boichat
> Sent: Tuesday, August 27, 2019 4:08 PM
> To: Wen Gong <[email protected]>
> Cc: open list:NETWORKING DRIVERS (WIRELESS) <linux-
> [email protected]>; [email protected]; Wen Gong
> <[email protected]>
> Subject: [EXT] Re: [PATCH 1/7] ath10k: enable RX bundle receive for sdio
> 
> On Tue, Aug 27, 2019 at 4:03 PM Wen Gong <[email protected]>
> wrote:
> >
> > > -----Original Message-----
> > > From: ath10k <[email protected]> On Behalf Of Nicolas
> > > Boichat
> > > Sent: Tuesday, August 27, 2019 3:41 PM
> > > To: Wen Gong <[email protected]>
> > > Cc: open list:NETWORKING DRIVERS (WIRELESS) <linux-
> > > [email protected]>; [email protected]
> > > Subject: [EXT] Re: [PATCH 1/7] ath10k: enable RX bundle receive for sdio
> > The bundled buffer len is 256 * 3 = 768, it has 256 bytes for each packet,
> the left size is padding which
> > Is not needed, but the left padding is not same for each packet, before read
> all the buffer from sdio bus,
> > It does not know each packet's act len, it only know the 1st packet's act 
> > len.
> > So it need to copy all the alloc_len's buffer to ensure it will not lose 
> > data.
> 
> Gotcha, thanks.
Patch v2 sent with the changes, https://patchwork.kernel.org/patch/11116681/
> 
> > > Actually, just use skb_put_data.
> > >
> > > Also, do you have the same issue as
> > > https://patchwork.kernel.org/patch/11116215/ w.r.t. act_len being
> > > incorrect?
> > >
> > > > +               pkt->status = 0;
> > > > +               skb_put(skb, pkt->act_len);
> 
> So I guess this is incorrect, see patchwork linked above.
> 
> > > > +               pkt_offset += pkt->alloc_len;
> > > >         }
> > > >
> > > >         return 0;
> > > >
> > >
> > > _______________________________________________
> > > ath10k mailing list
> > > [email protected]
> > > http://lists.infradead.org/mailman/listinfo/ath10k
> 
> _______________________________________________
> ath10k mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/ath10k

_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k

Reply via email to