On 2019-09-16 23:27, Johannes Berg wrote:
Without really looking at the code -

If station is ineligible for transmission in ieee80211_txq_may_transmit(), no packet will be delivered to FW. During the tests in push-pull mode with many clients, after several seconds, not a single station is an eligible
candidate for transmission since global time is smaller than all the
station's virtual airtime. As a consequence, the Tx has been blocked and
throughput is quite low.

You should rewrite this to be, erm, a bit more understandable in
mac80211 context. I assume you're speaking (mostly?) about ath10k, but I
have very little context there. "push pull mode"? "firmware"? These
things are not something mac80211 knows about.
Hi Johannes,

Thanks for your kindly reminder. Will rewrite the commit log.


Co-developed-by: Yibo Zhao <yi...@codeaurora.org>

That also seems wrong, should be Toke I guess, unless you intended for a
From: Toke to be present?
Do you mean it should be something like:

Co-developed-by: Toke Høiland-Jørgensen <t...@toke.dk>
Signed-off-by: Yibo Zhao <yi...@codeaurora.org>
Signed-off-by: Toke Høiland-Jørgensen <t...@toke.dk>

Am I understanding right?

johannes

--
Yibo

Reply via email to