On Fri, Nov 01, 2019 at 08:46:53AM -0700, Ben Greear wrote:
> > diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c
> > b/drivers/net/wireless/ath/ath10k/htt_rx.c
> > index 53f1095de8ff..ce0a16ebb8bb 100644
> > --- a/drivers/net/wireless/ath/ath10k/htt_rx.c
> > +++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
> > @@ -1285,6 +1285,12 @@ static void ath10k_process_rx(struct ath10k *ar,
> > struct sk_buff *skb)
> > status = IEEE80211_SKB_RXCB(skb);
> > + if (ar->monitor && !(ar->filter_flags & FIF_FCSFAIL) &&
> > + status->flag & RX_FLAG_FAILED_FCS_CRC) {
> > + dev_kfree_skb_any(skb);
> > + return;
> > + }
>
> Maybe worth adding a counter like 'rx_drop_crc' to the ath10k_debug struct
> and increment it here
> and also show in debugfs and/or ethtool stats?
Ok.
>
> And, maybe no check for ar->monitor, in case somehow the frame is still
> received
> with bad CRC even without monitor mode?
I think ath9k is also checking for "ah->is_monitoring" here:
https://elixir.bootlin.com/linux/v5.3.8/source/drivers/net/wireless/ath/ath9k/common.c#L96
And I didn't want to divert from this. Should I remove it anyway?
_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
