Eduardo Abinader <[email protected]> writes: > On Mon, 11 Nov 2019 at 09:50, Kalle Valo <[email protected]> wrote: > >> Eduardo Abinader <[email protected]> writes: >> >> > Signed-off-by: Eduardo Abinader <[email protected]> >> >> No empty commit logs, please. >> >> > --- a/drivers/net/wireless/ath/ath10k/mac.c >> > +++ b/drivers/net/wireless/ath/ath10k/mac.c >> > @@ -6786,13 +6786,13 @@ static int ath10k_sta_state(struct ieee80211_hw >> *hw, >> > /* >> > * Disassociation. >> > */ >> > - ath10k_dbg(ar, ATH10K_DBG_MAC, "mac sta %pM >> disassociated\n", >> > - sta->addr); >> > - >> > ret = ath10k_station_disassoc(ar, vif, sta); >> > if (ret) >> > ath10k_warn(ar, "failed to disassociate station: >> %pM vdev %i: %i\n", >> > sta->addr, arvif->vdev_id, ret); >> > + else >> > + ath10k_dbg(ar, ATH10K_DBG_MAC, "mac sta %pM >> disassociated\n", >> > + sta->addr); >> >> I don't understand, how is this better? >> > > Either one msg or the other? I think a bit cleaner log.
I don't see it that way, the else branch makes the code harder to read and for consistency it's better to always print the debug log. > --000000000000b3b5a805970e8f8f > Content-Type: text/html; charset="UTF-8" > Content-Transfer-Encoding: quoted-printable Please don't use HTML, I think the mailing lists drop all HTML mail automatically. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
